From 5c9be1c98dde615209fc657c0c75a0b40e073304 Mon Sep 17 00:00:00 2001
From: RenauxLeaInsee <153934662+RenauxLeaInsee@users.noreply.github.com>
Date: Fri, 29 Nov 2024 15:51:59 +0100
Subject: [PATCH] fix content type (#90)

* fix content type

* fix: surveyList type
---
 src/components/SurveyList/SurveyList.tsx | 13 ++++---------
 src/routes/$survey/resultats.tsx         |  4 +++-
 src/types/ContentSurvey.ts               |  3 ++-
 3 files changed, 9 insertions(+), 11 deletions(-)

diff --git a/src/components/SurveyList/SurveyList.tsx b/src/components/SurveyList/SurveyList.tsx
index 02b0ed3..0a82df7 100644
--- a/src/components/SurveyList/SurveyList.tsx
+++ b/src/components/SurveyList/SurveyList.tsx
@@ -4,19 +4,14 @@ import { fr } from "@codegouvfr/react-dsfr";
 import content from "resources/content.json";
 import { Card } from "@codegouvfr/react-dsfr/Card";
 import { List } from "@mui/material";
+import { ContentSurvey } from "types/ContentSurvey";
 
 export const SurveysList = () => {
   const { t } = useTranslation("SurveyHomepage");
 
-  const surveys = content.specifique
-    .map(survey => {
-      return {
-        titleShort: survey.titleShort,
-        id: survey.id,
-        disabledOnWelcomePage: survey.disabledOnWelcomePage,
-      };
-    })
-    .filter(survey => survey.disabledOnWelcomePage !== true);
+  const surveys: ContentSurvey[] = content.specifique.filter(
+    survey => survey.disabledOnWelcomePage !== true,
+  );
 
   return (
     <div>
diff --git a/src/routes/$survey/resultats.tsx b/src/routes/$survey/resultats.tsx
index cc680c8..b7357a4 100644
--- a/src/routes/$survey/resultats.tsx
+++ b/src/routes/$survey/resultats.tsx
@@ -22,7 +22,9 @@ function Results() {
     <section className={fr.cx("fr-col-12", "fr-col-md-6", "fr-pr-md-4w")}>
       <h3>{t("some results")}</h3>
       <h4>{results.title}</h4>
-      <img src={`/${results["picture-url"]}`} alt={results.legende} width={"100%"} />
+      {results["picture-url"] && (
+        <img src={`/${results["picture-url"]}`} alt={results.legende} width={"100%"} />
+      )}
       <Markdown className="fr-text--sm" content={results.legende} />
     </section>
   );
diff --git a/src/types/ContentSurvey.ts b/src/types/ContentSurvey.ts
index 3ceca97..330ebc1 100644
--- a/src/types/ContentSurvey.ts
+++ b/src/types/ContentSurvey.ts
@@ -1,6 +1,7 @@
 export type ContentSurvey = {
   id: string;
   isSurveyOnline: boolean;
+  disabledOnWelcomePage?: boolean
   messageSurveyOffline: string;
   messageInfoSurveyOffline: string;
   title: string;
@@ -14,7 +15,7 @@ export type ContentSurvey = {
     resultats: {
       title: string;
       "menu-title": string;
-      "picture-url": string;
+      "picture-url"?: string;
       legende: string;
       "link-url"?: string;
     };