Fix moog exrtraction #100
Merged
Fix moog exrtraction #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davdarras
reviewed
Jan 8, 2025
.../java/fr/insee/survey/datacollectionmanagement/DatacollectionManagementApplicationTests.java
Outdated
Show resolved
Hide resolved
| .andExpect(content().json(jsonAccreditation.toString(), false)); | ||
| Questioning questioning = questioningService.findbyId((long) idQuestioning); | ||
| .andExpect(content().json(jsonAccreditation, false)); | ||
| Questioning questioning = questioningService.findbyId(idQuestioning); | ||
| Set<QuestioningAccreditation> setAccreditationFound = questioning.getQuestioningAccreditations(); | ||
| QuestioningAccreditation accreditationFound = setAccreditationFound.stream() |
There was a problem hiding this comment.
maybe a first assert to check non empty list ?
| private final AddressRepository addressRepository; | ||
|
|
||
| final String getEventsQuery = "SELECT qe.id, date, type, survey_unit_id_su, campaign_id " | ||
| static final String GET_EVENTS_QUERY = "SELECT qe.id, date, type, survey_unit_id_su, campaign_id " |
| identifier, | ||
| id, | ||
| id_partitioning as batch_num | ||
| distinct on |
There was a problem hiding this comment.
is perf okay with all these queries change ?
| public static final String JUNE = "juin"; | ||
| public static final String JULY = "juillet"; | ||
| public static final String AUGUST = "août"; | ||
| private static final String SEPTEMBER = "septembre"; |
...shared/src/main/java/fr/insee/survey/datacollectionmanagement/metadata/enums/PeriodEnum.java
Outdated
Show resolved
Hide resolved
davdarras
approved these changes
Jan 8, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.