-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reference shapes #2
Conversation
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2 +/- ##
===========================================
+ Coverage 0 100.00% +100.00%
===========================================
Files 0 3 +3
Lines 0 19 +19
===========================================
+ Hits 0 19 +19
☔ View full report in Codecov by Sentry. |
b04eda9
to
5e3feee
Compare
…eSimplex This also fixes errors in the center function for those shapes.
Is ready for a review? Thanks for the improvements. |
Also, I think we should drop support for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some minor comments. I can handle them tomorrow, just wanted to point out what might change.
@maltezfaria I don't understand what you mean by how the vertex test constructors are ``too verbose'' -- if there is a more efficient way to test the expected output of vertices I'm all for it, but I didn't know how. |
I meant that SVector{3, SVector{2, Int64}}([0, 0], [1, 0], [0, 1]) can be replaced by SVector([0, 0], [1, 0], [0, 1]) and the tests will still pass. |
Implements some reference shapes to be used later for both interpolation and integration. Together with a push-forward map, this will later be used to interpolate and integrate over arbitrary elements.
Left to do:
ReferenceTriangle
andReferenceTetra
into aReferenceSimplex{N}
, similar to what is currently done forReferenceHyperCube