Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak the Pluto to Documenter pipeline #102

Merged
merged 8 commits into from
Oct 15, 2024
Merged

Tweak the Pluto to Documenter pipeline #102

merged 8 commits into from
Oct 15, 2024

Conversation

maltezfaria
Copy link
Member

@maltezfaria maltezfaria commented Oct 14, 2024

@maltezfaria maltezfaria marked this pull request as ready for review October 14, 2024 09:19
- links to notebooks are created during conversion to `.md`
Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.93%. Comparing base (597cc23) to head (523b466).
Report is 12 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #102       +/-   ##
===========================================
- Coverage   79.97%   65.93%   -14.04%     
===========================================
  Files          24       24               
  Lines        3021     3018        -3     
===========================================
- Hits         2416     1990      -426     
- Misses        605     1028      +423     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maltezfaria
Copy link
Member Author

@gregoirepourtier I made a few minor changes to your original implementation. My goal was to keep it simple for now. We can always make a more complex workflow later if we feel it is needed.

Copy link
Collaborator

@gregoirepourtier gregoirepourtier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the description of the generated example, everything else LGTM :)

docs/src/pluto-examples/toy_example.jl Show resolved Hide resolved
@maltezfaria maltezfaria merged commit 5d3814e into main Oct 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants