Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not push_back compute event to host_tasks list #1807

Merged
merged 4 commits into from
Aug 24, 2024

Conversation

oleksandr-pavlyk
Copy link
Collaborator

Do not push_back compute event to host_tasks list.

This is even though sequence of tasks represented by dot_ev does contain host_task to manage temporary USM allocations.


  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

This is even though sequence of tasks represented by dot_ev
does contain host_task to manage temporary USM allocations.
Copy link

github-actions bot commented Aug 22, 2024

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

Copy link

Array API standard conformance tests for dpctl=0.18.0dev0=py310hdf72452_342 ran successfully.
Passed: 894
Failed: 1
Skipped: 119

@coveralls
Copy link
Collaborator

coveralls commented Aug 22, 2024

Coverage Status

coverage: 87.903% (+0.002%) from 87.901%
when pulling 60969b4 on dont-add-compute-event-into-host-task-list
into 4297fef on master.

@ndgrigorian
Copy link
Collaborator

  • boolean_indexing.cpp
  • repeat.cpp
  • dot.cpp (changed here)

These are the files where we add compute events to our vectors of host tasks. It may be worth removing them as well.

Fix two additional instances pointed out by @ndgrigorian
during PR review.
Copy link

Array API standard conformance tests for dpctl=0.18.0dev0=py310hdf72452_351 ran successfully.
Passed: 894
Failed: 1
Skipped: 119

ndgrigorian and others added 2 commits August 24, 2024 09:58
Copy link
Collaborator

@ndgrigorian ndgrigorian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

Array API standard conformance tests for dpctl=0.18.0dev0=py310hdf72452_356 ran successfully.
Passed: 894
Failed: 1
Skipped: 119

@oleksandr-pavlyk oleksandr-pavlyk merged commit 6174a93 into master Aug 24, 2024
39 of 47 checks passed
@oleksandr-pavlyk oleksandr-pavlyk deleted the dont-add-compute-event-into-host-task-list branch August 24, 2024 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants