Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement dedicated strided full kernel and add order="K" support to constructors #1808

Merged
merged 10 commits into from
Aug 24, 2024
Merged

Implement dedicated strided full kernel and add order="K" support to constructors #1808

merged 10 commits into from
Aug 24, 2024

Conversation

ndgrigorian
Copy link
Collaborator

@ndgrigorian ndgrigorian commented Aug 23, 2024 •
edited by oleksandr-pavlyk
Loading

This PR implements a strided kernel for full to enable order="K" support in empty_like, full_like, ones_like, and zeros_like.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 23, 2024 •
edited
Loading

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@github-actions GitHub Actions
Copy link

Array API standard conformance tests for dpctl=0.18.0dev0=py310hdf72452_348 ran successfully.
Passed: 894
Failed: 1
Skipped: 119

@github-actions GitHub Actions
Copy link

Array API standard conformance tests for dpctl=0.18.0dev0=py310hdf72452_348 ran successfully.
Passed: 895
Failed: 0
Skipped: 119

@github-actions GitHub Actions
Copy link

Array API standard conformance tests for dpctl=0.18.0dev0=py310hdf72452_349 ran successfully.
Passed: 894
Failed: 1
Skipped: 119

@ndgrigorian
Implement dedicated strided full kernel
7ffc449
@ndgrigorian
Adds order="K" support to array-like functions
6d2a3ef 
`empty_like`, `zeros_like`, `ones_like`, and `full_like` all gain this support

Slips in changes to typos in docstrings
@ndgrigorian
Array-like constructors now default to order="K"
fbb162c 
Also reverts a change to how `order` arg validation is handled to fix a failing test
@github-actions GitHub Actions
Copy link

Array API standard conformance tests for dpctl=0.18.0dev0=py310hdf72452_349 ran successfully.
Passed: 894
Failed: 1
Skipped: 119

@github-actions GitHub Actions
Copy link

Array API standard conformance tests for dpctl=0.18.0dev0=py310hdf72452_350 ran successfully.
Passed: 894
Failed: 1
Skipped: 119

@coveralls
Copy link
Collaborator

coveralls commented Aug 23, 2024 •
edited
Loading

Coverage Status

coverage: 87.9% (-0.003%) from 87.903%
when pulling ba7fa73 on strided-full-kernel
into cfba263 on master.

@ndgrigorian ndgrigorian changed the title Implement dedicated strided full kernel, add order="K" and out support to constructors Implement dedicated strided full kernel and add order="K" support to constructors Aug 23, 2024
@github-actions GitHub Actions
Copy link

Array API standard conformance tests for dpctl=0.18.0dev0=py310hdf72452_353 ran successfully.
Passed: 894
Failed: 1
Skipped: 119

@github-actions GitHub Actions
Copy link

Array API standard conformance tests for dpctl=0.18.0dev0=py310hdf72452_354 ran successfully.
Passed: 894
Failed: 1
Skipped: 119

@github-actions GitHub Actions
Copy link

Array API standard conformance tests for dpctl=0.18.0dev0=py310hdf72452_354 ran successfully.
Passed: 894
Failed: 1
Skipped: 119

@ndgrigorian ndgrigorian marked this pull request as ready for review August 23, 2024 21:41
@github-actions GitHub Actions
Copy link

Array API standard conformance tests for dpctl=0.18.0dev0=py310hdf72452_355 ran successfully.
Passed: 894
Failed: 1
Skipped: 119

@github-actions GitHub Actions
Copy link

Array API standard conformance tests for dpctl=0.18.0dev0=py310hdf72452_358 ran successfully.
Passed: 895
Failed: 0
Skipped: 119

@ndgrigorian
Factor out common order processing code in array-like constructors
ba7fa73 
This introduces a new utility function for constructors `_normalize_order`
@github-actions GitHub Actions
Copy link

Array API standard conformance tests for dpctl=0.18.0dev0=py310hdf72452_359 ran successfully.
Passed: 894
Failed: 1
Skipped: 119

oleksandr-pavlyk
oleksandr-pavlyk approved these changes Aug 24, 2024
View reviewed changes
Copy link
Collaborator

@oleksandr-pavlyk oleksandr-pavlyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ndgrigorian ! Looks good to me

@ndgrigorian ndgrigorian merged commit f0379e6 into master Aug 24, 2024
46 of 53 checks passed
@ndgrigorian ndgrigorian deleted the strided-full-kernel branch August 24, 2024 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleksandr-pavlyk oleksandr-pavlyk oleksandr-pavlyk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ndgrigorian @coveralls @oleksandr-pavlyk