Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contributions to strided full like pr #1809

Merged

Conversation

oleksandr-pavlyk
Copy link
Collaborator

In full_like(proto_array, fill_value=value_array, order='K') the change orders kernel to copy from value_array into new allocation after tasks that may be populating value_array.

Also corrected comment in py_internal::usm_ndarray_full C++ function.


  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

Copy link

github-actions bot commented Aug 23, 2024

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

Copy link

Array API standard conformance tests for dpctl=0.18.0dev0=py310hdf72452_352 ran successfully.
Passed: 895
Failed: 0
Skipped: 119

Copy link
Collaborator

@ndgrigorian ndgrigorian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @oleksandr-pavlyk for noticing this.

@oleksandr-pavlyk oleksandr-pavlyk merged commit 2282c5b into strided-full-kernel Aug 23, 2024
46 of 53 checks passed
@oleksandr-pavlyk oleksandr-pavlyk deleted the contributions-to-strided-full-like-pr branch August 23, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants