Add dpctl.tensor._tensor_elementwise_impl._divide_by_scalar utility function and use it in statistical functions
#1820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This brings significant performance improvement for Lloyd algorithm benchmark.
…enominator in `TrueDivideFunctor`
The scalar is expected to overflow to infinity when cast to the array's type and the result should be 0 (for a finite numerator)
|
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
|
Array API standard conformance tests for dpctl=0.18.0dev0=py310hdf72452_392 ran successfully. |
oleksandr-pavlyk
changed the title
dpctl.tensor._tensor_elementwise_impl._divide_by_scalar utility functiondpctl.tensor._tensor_elementwise_impl._divide_by_scalar utility function and use it in statistical functions
oleksandr-pavlyk
requested changes
Sep 5, 2024
dpctl/tensor/libtensor/source/elementwise_functions/true_divide.cpp
Outdated
Show resolved
Hide resolved
dpctl/tensor/libtensor/source/elementwise_functions/true_divide.cpp
Outdated
Show resolved
Hide resolved
dpctl/tensor/libtensor/source/elementwise_functions/true_divide.cpp
Outdated
Show resolved
Hide resolved
dpctl/tensor/libtensor/source/elementwise_functions/true_divide.cpp
Outdated
Show resolved
Hide resolved
dpctl/tensor/libtensor/source/elementwise_functions/true_divide.cpp
Outdated
Show resolved
Hide resolved
|
Array API standard conformance tests for dpctl=0.18.0dev0=py310hdf72452_393 ran successfully. |
Apply review suggestions
ndgrigorian
force-pushed
the
divide-by-scalar-integer
branch
from
775ba90
to
6bde41f
Compare
oleksandr-pavlyk
approved these changes
Sep 5, 2024
|
Array API standard conformance tests for dpctl=0.18.0dev0=py310hdf72452_393 ran successfully. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes adding a utility function
_divide_by_scalarto the_tensor_elementwise_implsub-module.This function improves the performance of division where the denominator is a Python scalar by avoiding a call to
asarrayand allocating device memory.This function is also deployed to the statistical functions.
Slips in a change to remove a superfluous
wait()from_clip.py