Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I18n Translation implementation #33

Merged
merged 7 commits into from
Jan 30, 2024
Merged

I18n Translation implementation #33

merged 7 commits into from
Jan 30, 2024

Conversation

TheMeinerLP
Copy link
Member

@TheMeinerLP TheMeinerLP commented Jan 30, 2024

Proposed changes

Fixes #19

Types of changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of
them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.

  • I have read the CONTRIBUTING.md
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you
did and what alternatives you considered, etc...

@TheMeinerLP TheMeinerLP requested a review from a team as a code owner January 30, 2024 21:51
@TheMeinerLP TheMeinerLP marked this pull request as draft January 30, 2024 21:51
@TheMeinerLP TheMeinerLP marked this pull request as ready for review January 30, 2024 21:51
@TheMeinerLP TheMeinerLP merged commit 5af255b into main Jan 30, 2024
10 checks passed
@TheMeinerLP TheMeinerLP mentioned this pull request Jan 30, 2024
@TheMeinerLP TheMeinerLP deleted the feature/i18n branch February 4, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

I18n Support
1 participant