fix: fixed history rollback #2367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dordsor21
commented
Jul 19, 2023
•
dordsor21
commented
- Actual issue is setting the editsession changeset to the changeset we're undoing...?!?! And so we start arbitrarily overriding the history we want to save and completely and utterly fucking everything. Please let's not do that again. Thanks :)
- Also go ahead and clean up other parts of this, with more appropriate operators used
- Fixes Extreme freakout when rolling back history #2366
- Actual issue is settings the editsession changeset to the changeset we're undoing...?!?! And so we start abirtrarily overriding the history we want to do and completely and and utterly fucking everything. Please let's not do that again. Thanks :) - Also go ahead and clean up other parts of this, with more appropriate operators used - Fixes #2366
SirYwell
requested changes
Jul 25, 2023
worldedit-core/src/main/java/com/fastasyncworldedit/core/history/DiskStorageHistory.java
Outdated
Show resolved
Hide resolved
worldedit-core/src/main/java/com/sk89q/worldedit/command/HistorySubCommands.java
Outdated
Show resolved
Hide resolved
worldedit-core/src/main/java/com/fastasyncworldedit/core/database/RollbackDatabase.java
Outdated
Show resolved
Hide resolved
SirYwell
approved these changes
Sep 30, 2023
|
Please take a moment and address the merge conflicts of your pull request. Thanks! |
NotMyFault
approved these changes
Nov 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.