Fixes mask deadlock for angle mask

[TheMeinerLP]

Overview

Fixes #2448

Description

This PR fixes some deadlock scenarios from angle mask.
I reverted some code peaces but try to keep it native to java.

Submitter Checklist

Preview Give feedback

1. Make sure you are opening from a topic branch (/feature/fix/docs/ branch (right side)) and not your main branch.
2. Ensure that the pull request title represents the desired changelog entry.
3. New public fields and methods are annotated with @since TODO.
4. I read and followed the contribution guidelines.

[dordsor21]

This is completely negating the entire point of the call lock - we should NOT be editing a chunk set/get whilst the parent is being called. The fix is to correctly synchronise/wait elsewhere on the call chain, and the fact it's locking is an indicator that improvements to the order need to be changed.

[TheMeinerLP]

This is completely negating the entire point of the call lock - we should NOT be editing a chunk set/get whilst the parent is being called. The fix is to correctly synchronise/wait elsewhere on the call chain, and the fact it's locking is an indicator that improvements to the order need to be changed.

But the current code is "unstable" and makes the behavior to crash servers.

Apply this a temp solution to fix the issues and after that we can apply a better solution.

[SirYwell]

This solution isn't really better - it is just unsafe with other unforseen side effects.

[TheMeinerLP]

This solution isn't really better - it is just unsafe with other unforseen side effects.

Thats true, what i learned. If some code does not work or makes issues. Rollback it and apply a better solution.

[MrJoshuaT]

This would seem to be more stable than any 2.7.x or 2.8.x versions, even if not correct this is more like the 2.6.x behaviour which was very stable. Our 1.20.1 public creative server was crashing constantly with users doing any angle mask, so we had to disable all of them.

In 2.7.x or 2.8.x when a user did a large size angle mask brush, 30 or more, the server would stop ticking and crash every time. With this change this behaviour is better - there still a side effect when a large brush is used constantly FAWE will lock up for that user, but the server will not crash, from initial testing, which is better behaviour

[dordsor21]

Closing in favour of #2461