Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid premature trimming in RegionIntersection #2471

Merged
merged 1 commit into from
Oct 22, 2023

Conversation

SirYwell
Copy link
Member

Overview

Fixes #2470

Description

RegionIntersection can delegate to Region#processSet of one of the regions only if only this region overlaps with the chunk to process.
Otherwise, we need to check if any region contains a block before we can trim it, i.e. delegate to the default implementation of processSet.

Submitter Checklist

Preview Give feedback

@SirYwell SirYwell requested a review from a team as a code owner October 22, 2023 11:38
@github-actions github-actions bot added the Bugfix This PR fixes a bug label Oct 22, 2023
Copy link
Member

@TheMeinerLP TheMeinerLP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NotMyFault NotMyFault added the hacktoberfest-accepted Apply this label on PRs label Oct 22, 2023
@NotMyFault NotMyFault merged commit 9fff77c into main Oct 22, 2023
8 checks passed
@NotMyFault NotMyFault deleted the fix/RegionIntersection-processSet branch October 22, 2023 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bugfix This PR fixes a bug hacktoberfest-accepted Apply this label on PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Merged plots regions are incorrect
4 participants