Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup rawtypes warnings in relighting code #2472

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

SirYwell
Copy link
Member

Overview

Description

We previously used the raw type IQueueChunk as type parameter. However, none of the code depends on that specific interface, we can just fall back to the upper bound IChunk. This allows to get rid of warnings and suppressions.

Submitter Checklist

Preview Give feedback

@SirYwell SirYwell requested a review from a team as a code owner October 23, 2023 14:12
@github-actions github-actions bot added the chore label Oct 23, 2023
@SirYwell SirYwell force-pushed the refactor/warnings-cleanup branch from 37daeb2 to a379d60 Compare October 23, 2023 14:29
@NotMyFault NotMyFault added the hacktoberfest-accepted Apply this label on PRs label Oct 23, 2023
@NotMyFault NotMyFault merged commit 256ef74 into main Oct 26, 2023
10 checks passed
@NotMyFault NotMyFault deleted the refactor/warnings-cleanup branch October 26, 2023 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore hacktoberfest-accepted Apply this label on PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants