Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use FastSchematicReader by default #2478

Merged
merged 1 commit into from
Nov 18, 2023
Merged

Conversation

SirYwell
Copy link
Member

@SirYwell SirYwell commented Nov 1, 2023

Overview

Description

HashMultiMap has no guarantees about the order of the values for a key. In our case, this leads to SPONGE_SCHEMATIC being first when iterating in ClipboardFormats.findByExtension(...). We want FAST to come before, therefore we should use a MultiMap where values are in the order they are registered. This matches the registeredFormats list used by findByFile.

The change to the command is needed to allow actually enforcing a different schematic format.

Submitter Checklist

Preview Give feedback

@SirYwell SirYwell requested a review from a team as a code owner November 1, 2023 08:17
@NotMyFault NotMyFault requested a review from dordsor21 November 2, 2023 06:53
@dordsor21 dordsor21 merged commit 1a7f555 into main Nov 18, 2023
8 checks passed
@dordsor21 dordsor21 deleted the perf/prefer-fast-schematic-reader branch November 18, 2023 14:11
@NotMyFault NotMyFault added the Feature This PR adds a new feature label Nov 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature This PR adds a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants