Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for 1.17.1 and 1.18.2 #2540

Closed
wants to merge 2 commits into from
Closed

Conversation

NotMyFault
Copy link
Member

@NotMyFault NotMyFault commented Jan 6, 2024

As proven evidently, 1.17.1 is used by ~1.9% and 1.18.2 by 4.7% of our user base, declaring a stagnating or no interest in these versions, it's only logical to drop support for them.
Given the fast-pacing release economy of Minecraft, it's not viable to upkeep versions released more than ~3 years ago only a small fraction of our user base sticks to.

Screenshot 2024-01-06 at 11 04 13

@NotMyFault NotMyFault added the Breaking changes This PR causes a breaking change label Jan 6, 2024
@NotMyFault NotMyFault requested a review from a team as a code owner January 6, 2024 10:09
Copy link
Member

@PierreSchwang PierreSchwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚮

@SirYwell
Copy link
Member

SirYwell commented Jan 6, 2024

I think 4.7% is still a fair amount. Is there any technical reason to drop it?

@NotMyFault
Copy link
Member Author

I think 4.7% is still a fair amount.

Providing compatibility for a stagnating minority has never been a goal of this project. 1.8.8 is used by 8.3%, which is an even more "fair amount" following your logic.

@SirYwell
Copy link
Member

SirYwell commented Jan 6, 2024

Providing compatibility for a stagnating minority has never been a goal of this project. 1.8.8 is used by 8.3%, which is an even more "fair amount" following your logic.

Not supporting 1.8.8 has a very strong technical reason as we'd basically need to maintain two plugins. That's why I'm asking. Not supporting a version that has basically zero overhead to maintain (besides probably copy-pasting some code) does not seem reasonable to me.

@dordsor21
Copy link
Member

Yeah I

Providing compatibility for a stagnating minority has never been a goal of this project. 1.8.8 is used by 8.3%, which is an even more "fair amount" following your logic.

Not supporting 1.8.8 has a very strong technical reason as we'd basically need to maintain two plugins. That's why I'm asking. Not supporting a version that has basically zero overhead to maintain (besides probably copy-pasting some code) does not seem reasonable to me.

I agree with this tbh, there's no real need to remove support yet

@NotMyFault
Copy link
Member Author

NotMyFault commented Jan 6, 2024

I'll withdraw my attention from anything older than 1.19.4 because I would rather not waste my time with 3+ years old unmaintained versions.

@NotMyFault NotMyFault closed this Jan 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking changes This PR causes a breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants