Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(GriefDefender): invalidate mask on claim change #2903

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

PierreSchwang
Copy link
Member

Overview

Fixes #2889

Description

No idea if it works, ain't gonna pay 15 euros just for testing

Submitter Checklist

Preview Give feedback

@PierreSchwang PierreSchwang requested a review from a team as a code owner August 30, 2024 17:04
@github-actions github-actions bot added the Bugfix This PR fixes a bug label Aug 30, 2024
@iiAhmedYT
Copy link

Whoever tests for 15euro, how did you manage that 😭 I WAN THAT TOO

@PierreSchwang
Copy link
Member Author

Whoever tests for 15euro, how did you manage that 😭 I WAN THAT TOO

uhm, what? what do you want too? lol

@iiAhmedYT
Copy link

iiAhmedYT commented Aug 30, 2024

the possibility of people accepting to pay 15eur just for a pr request test

@PierreSchwang
Copy link
Member Author

I don't want to pay 15 USD for GriefDefender to test this PR is what I meant haha
GitHub is not maintained anymore - so to test it, I'd have to buy GriefDefender, which I don't want to

@iiAhmedYT
Copy link

oh, i thought that was someone not a plugin 😭

Copy link
Member

@SirYwell SirYwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That could work, maybe @TWME-TW can test the changes.

@TWME-TW
Copy link

TWME-TW commented Sep 1, 2024

That could work, maybe @TWME-TW can test the changes.

Yes I can test it, I will test it on September 3rd

@TWME-TW
Copy link

TWME-TW commented Sep 2, 2024

@PierreSchwang After testing, this PR successfully fixed the problem

@PierreSchwang
Copy link
Member Author

Thank you for testing and validating!

@PierreSchwang PierreSchwang merged commit 4b099d3 into main Sep 3, 2024
9 checks passed
@PierreSchwang PierreSchwang deleted the fix/griefDefender branch September 3, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bugfix This PR fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FastAsyncWorldEdit bypasses GriefDefender protection
5 participants