Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Un-break for versions <1.21.3 #2988

Merged
merged 4 commits into from
Nov 11, 2024
Merged

Un-break for versions <1.21.3 #2988

merged 4 commits into from
Nov 11, 2024

Conversation

SirYwell
Copy link
Member

@SirYwell SirYwell commented Nov 11, 2024

Overview

Fixes #2987

Description

Compile against 1.21 again to avoid bytecode incompatible with version <1.21.3. Also apply an upstream patch and remove now-unneeded code.

The upstream patch initially included doesn't support custom biomes pre 1.21.3, so we need to revisit that separately.

Submitter Checklist

Preview Give feedback

me4502 and others added 2 commits November 11, 2024 08:57
(cherry picked from commit 292dae65cb01929dc2158f09bdb19fdc82b3669f)
@SirYwell SirYwell requested a review from a team as a code owner November 11, 2024 12:32
@github-actions github-actions bot added the Bugfix This PR fixes a bug label Nov 11, 2024
@PierreSchwang PierreSchwang requested a review from a team November 11, 2024 17:26
@dordsor21 dordsor21 merged commit e3fc35c into main Nov 11, 2024
11 checks passed
@dordsor21 dordsor21 deleted the fix/use-registry branch November 11, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bugfix This PR fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to start server
5 participants