Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send forget packet to avoid invisible chunk sections #3005

Merged
merged 1 commit into from
Nov 23, 2024

Conversation

SirYwell
Copy link
Member

Overview

Fixes #2989

Description

The vanilla 1.21.3 client handles full chunk packets in a way that previously empty chunk sections are not rendered. By forcing the client to drop the chunk completely first, we can ensure that the blocks are rendered again. This might cause some higher load for the client, so we should check if this is still a problem once 1.21.4 is released/supported.

Submitter Checklist

Preview Give feedback

@SirYwell SirYwell requested a review from a team as a code owner November 22, 2024 15:30
@github-actions github-actions bot added the Bugfix This PR fixes a bug label Nov 22, 2024
Copy link
Member

@PierreSchwang PierreSchwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sound reasonable - weird that that's a thing in 1.21.3 tbf

@dordsor21 dordsor21 merged commit c4267b3 into main Nov 23, 2024
9 checks passed
@dordsor21 dordsor21 deleted the fix/invisible-chunk-sections branch November 23, 2024 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bugfix This PR fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New set blocks not rendered in previously empty chunks
3 participants