Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce code duplication of PaperweightBlockMaterial #3041

Merged
merged 1 commit into from
Dec 23, 2024
Merged

Reduce code duplication of PaperweightBlockMaterial #3041

merged 1 commit into from
Dec 23, 2024

Conversation

SirYwell
Copy link
Member

Overview

Description

We can deduplicate and simplify some things there.

Submitter Checklist
Preview Give feedback

@SirYwell SirYwell requested a review from a team as a code owner December 23, 2024 18:01
@github-actions github-actions bot added the chore label Dec 23, 2024
NotMyFault
NotMyFault approved these changes Dec 23, 2024
View reviewed changes
Copy link
Member

@NotMyFault NotMyFault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh that's smart

PierreSchwang
PierreSchwang approved these changes Dec 23, 2024
View reviewed changes
Copy link
Member

@PierreSchwang PierreSchwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks reasonable

@NotMyFault NotMyFault merged commit 0cf9813 into main Dec 23, 2024
9 checks passed
@NotMyFault NotMyFault deleted the refactor/PaperweightBlockMaterial branch December 23, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PierreSchwang PierreSchwang PierreSchwang approved these changes

@NotMyFault NotMyFault NotMyFault approved these changes

Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SirYwell @NotMyFault @PierreSchwang