Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate query proposals #684

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Integrate query proposals #684

merged 1 commit into from
Dec 5, 2024

Conversation

CarlosLopezDeLara
Copy link
Contributor

@CarlosLopezDeLara CarlosLopezDeLara commented Nov 20, 2024

Changelog

- description: |
    Integrate queryProposals (GetProposals)
# uncomment types applicable to the change:
  type:
   - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - refactoring    # QoL changes
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

This query is relatively new in consensus and will be useful for IntersectMBO/cardano-cli#954

How to trust this PR

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

Copy link
Contributor

@carbolymer carbolymer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Can you test the query on the live node prior to merging?

cardano-api/internal/Cardano/Api/Query.hs Outdated Show resolved Hide resolved
Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

cardano-api/internal/Cardano/Api/Query/Expr.hs Outdated Show resolved Hide resolved
@smelc
Copy link
Contributor

smelc commented Nov 25, 2024

@carbolymer> I think it'd be nicer for the developer experience to merge this before having tested it on cardano-testnet, because testing requires building both cardano-node and cardano-cli locally with SRPs, which is cumbersome. I don't think there's much harm to be done if we merge this. It's not like 1. it can be very wrong and 2. users are going to jump on this feature.

@smelc
Copy link
Contributor

smelc commented Nov 26, 2024

Agreed during the team meeting to merge after the release (the one being worked on by @neilmayhew: #687).

@smelc
Copy link
Contributor

smelc commented Nov 29, 2024

Putting to draft to make sure we don't merge until we're sure the behavior we observe in IntersectMBO/cardano-node#6045 is the intended one (as agreed on Slack, we don't want to merge until we're sure our code (and the ledger's code) is correct).

@smelc smelc marked this pull request as ready for review December 4, 2024 12:24
@smelc
Copy link
Contributor

smelc commented Dec 4, 2024

We have confirmed that the behavior of the query we observe on cardano-testnet is correct, so merging. cc @CarlosLopezDeLara

@smelc smelc added this pull request to the merge queue Dec 4, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Dec 4, 2024
@smelc smelc added this pull request to the merge queue Dec 4, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Dec 4, 2024
@smelc smelc force-pushed the cl/queryProposals branch from 8b952e5 to b2c04da Compare December 5, 2024 10:33
@smelc smelc enabled auto-merge December 5, 2024 10:33
@smelc smelc added this pull request to the merge queue Dec 5, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Dec 5, 2024
@smelc smelc merged commit 6a42210 into master Dec 5, 2024
29 checks passed
@smelc smelc deleted the cl/queryProposals branch December 5, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants