-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate query proposals #684
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Can you test the query on the live node prior to merging?
5eb4b1a
to
c57419b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@carbolymer> I think it'd be nicer for the developer experience to merge this before having tested it on |
Agreed during the team meeting to merge after the release (the one being worked on by @neilmayhew: #687). |
6abc6de
to
8b952e5
Compare
Putting to draft to make sure we don't merge until we're sure the behavior we observe in IntersectMBO/cardano-node#6045 is the intended one (as agreed on Slack, we don't want to merge until we're sure our code (and the ledger's code) is correct). |
We have confirmed that the behavior of the query we observe on |
8b952e5
to
b2c04da
Compare
Changelog
Context
This query is relatively new in consensus and will be useful for IntersectMBO/cardano-cli#954
How to trust this PR
Checklist