Disambiguate DRep being a key or a script in certificate descriptions

IntersectMBO · Jan 8, 2025 · 61ff2f8 · 61ff2f8
1 parent 0067de6
commit 61ff2f8
Showing 1 changed file with 18 additions and 6 deletions.
diff --git a/cardano-cli/src/Cardano/CLI/EraBased/Run/Governance/DRep.hs b/cardano-cli/src/Cardano/CLI/EraBased/Run/Governance/DRep.hs
@@ -3,6 +3,7 @@
 {-# LANGUAGE GADTs #-}
 {-# LANGUAGE LambdaCase #-}
 {-# LANGUAGE NamedFieldPuns #-}
+{-# LANGUAGE OverloadedStrings #-}
 {-# LANGUAGE RankNTypes #-}
 {-# LANGUAGE ScopedTypeVariables #-}
 {-# LANGUAGE TypeApplications #-}
@@ -123,7 +124,7 @@ runGovernanceDRepRegistrationCertificateCmd
             makeDrepRegistrationCertificate
               req
               (pcaAnchor <$> mAnchor)
-          description = Just @TextEnvelopeDescr "DRep Key Registration Certificate"
+          description = Just $ hashSourceToDescription drepHashSource "Registration Certificate"
 
       firstExceptT RegistrationWriteFileError
         . newExceptT
@@ -145,11 +146,10 @@ runGovernanceDRepRetirementCertificateCmd
     conwayEraOnwardsConstraints w $ do
       drepCredential <- modifyError GovernanceCmdKeyReadError $ readDRepCredential drepHashSource
       makeDrepUnregistrationCertificate (DRepUnregistrationRequirements w drepCredential deposit)
-        & writeFileTextEnvelope outFile (Just genKeyDelegCertDesc)
+        & writeFileTextEnvelope
+          outFile
+          (Just $ hashSourceToDescription drepHashSource "Retirement Certificate")
         & modifyError GovernanceCmdTextEnvWriteError . newExceptT
-   where
-    genKeyDelegCertDesc :: TextEnvelopeDescr
-    genKeyDelegCertDesc = "DRep Retirement Certificate"
 
 runGovernanceDRepUpdateCertificateCmd
   :: ()
@@ -172,7 +172,10 @@ runGovernanceDRepUpdateCertificateCmd
               (DRepUpdateRequirements w drepCredential)
               (pcaAnchor <$> mAnchor)
       firstExceptT GovernanceCmdTextEnvWriteError . newExceptT $
-        writeFileTextEnvelope outFile (Just "DRep Update Certificate") updateCertificate
+        writeFileTextEnvelope
+          outFile
+          (Just $ hashSourceToDescription drepHashSource "Update Certificate")
+          updateCertificate
 
 runGovernanceDRepMetadataHashCmd
   :: ()
@@ -211,3 +214,12 @@ runGovernanceDRepMetadataHashCmd
     fetchURLToGovernanceCmdError
       :: ExceptT FetchURLError IO ByteString -> ExceptT GovernanceCmdError IO ByteString
     fetchURLToGovernanceCmdError = withExceptT GovernanceCmdFetchURLError
+
+hashSourceToDescription :: DRepHashSource -> TextEnvelopeDescr -> TextEnvelopeDescr
+hashSourceToDescription source what =
+  ( case source of
+      DRepHashSourceScript _ -> "DRep Script"
+      DRepHashSourceVerificationKey _ -> "DRep Key"
+  )
+    <> " "
+    <> what