Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create-testnet-data: document in more details subtleties of Conway genesis initialization #1003

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

smelc
Copy link
Contributor

@smelc smelc commented Jan 6, 2025

Changelog

- description: |
    Give more details regarding creation of Conway genesis in comments (see https://github.com/IntersectMBO/cardano-ledger/issues/4782)
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - refactoring    # QoL changes
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  - documentation  # change in code docs, haddocks...

Context

Follow-up of #991 (comment)

How to trust this PR

It's only comments

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • Self-reviewed the diff

@smelc smelc marked this pull request as ready for review January 6, 2025 09:34
@smelc smelc added this pull request to the merge queue Jan 7, 2025
Merged via the queue into master with commit e95324d Jan 7, 2025
60 of 79 checks passed
@smelc smelc deleted the smelc/more-details-in-conway-genesis-initialization branch January 7, 2025 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants