Add anchor data hash checks to remaining governance action commands #915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
palas
added
enhancement
palas
requested review from
Jimbo4350,
newhoggy,
carbolymer,
smelc,
kevinhammond and
disassembler
as code owners
carbolymer
reviewed
Sep 25, 2024
carbolymer
reviewed
Sep 25, 2024
carbolymer
reviewed
Sep 25, 2024
carbolymer
approved these changes
Sep 25, 2024
palas
force-pushed
the
add-hash-validation2
branch
from
0d4e93d to
9aae3ce
Compare
Co-authored-by: Mateusz Galazyn <228866+carbolymer@users.noreply.github.com>
palas
force-pushed
the
add-hash-validation2
branch
from
9aae3ce to
93027e4
Compare
3 tasks
Jimbo4350
reviewed
Sep 25, 2024
| @@ -3569,6 +3569,65 @@ pAnchorDataHash = | |||
| , Opt.help "Proposal anchor data hash (obtain it with \"cardano-cli hash anchor-data ...\")" | |||
| ] | |||
|
|
|||
| data HashCheckParamInfo anchorData | |||
There was a problem hiding this comment.
This type has incredibly poor type safety.
| ] | ||
| ] | ||
|
|
||
| proposalHashCheckInfo :: HashCheckParamInfo ProposalUrl |
There was a problem hiding this comment.
Please turn these into stand alone parsers. You can create a function that creates a parser which is the usual style we have.
| @@ -70,8 +70,11 @@ instance Error GovernanceActionsError where | |||
| <+> "hash:" | |||
| <+> pretty (displayException fetchErr) | |||
|
|
|||
| data AnchorDataTypeCheck = ProposalCheck | |||
| data AnchorDataTypeCheck | |||
There was a problem hiding this comment.
This needs to be commented.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Context
This is another step forward on addressing #882.
Previous related PR: #910
This only adds checks to commands inside
governance action. There are several other places where to add the check, but better to go step by step.How to trust this PR
I have adapted test for all commands but one, to validate the new functionality, and that gives me a lot of confidence. I would try to check that the code style is good, I didn't introduce any bugs, the parameter structure and names make sense, and the help is comprehensive and comprehensible.
Checklist