-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement command "query proposals" #984
Conversation
bf6f494
to
29eae83
Compare
29eae83
to
89d2ac8
Compare
0ff8372
to
bcdbaeb
Compare
bcdbaeb
to
53a66bd
Compare
2050f74
to
a89c623
Compare
a89c623
to
69def06
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I cannot find any issues by looking at the code.
It would be good to also test:
- Querying for more than one governance action ids at the same time
- Query using the
--all-proposals
flag - Checking the result is the same as for
cardano-cli conway query gov-state | jq .proposals
as in the acceptance criteria.
I've also noticed that it is not clear in the documentation generated that you can actually query for several action ids. But I've checked and it is done the same as for other commands, so this PR is fine.
@palas> Yep we actually did all of this manually with @CarlosLopezDeLara in |
69def06
to
54f4a6d
Compare
Changelog
Context
Fixes #903
How to trust this PR
Tested with
cardano-testnet
: https://github.com/IntersectMBO/cardano-node/commits/smelc/test-query-proposals/Checklist