Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement command "query proposals" #984

Merged
merged 3 commits into from
Dec 11, 2024
Merged

Conversation

smelc
Copy link
Contributor

@smelc smelc commented Nov 28, 2024

Changelog

- description: |
    Implement the `query proposals` command
# uncomment types applicable to the change:
  type:
  - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - refactoring    # QoL changes
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Fixes #903

How to trust this PR

Tested with cardano-testnet: https://github.com/IntersectMBO/cardano-node/commits/smelc/test-query-proposals/

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@smelc smelc added the next-update Needs a dependency to be updated to be merged label Nov 28, 2024
@smelc smelc force-pushed the smelc/cl/implement-query-proposals branch from bf6f494 to 29eae83 Compare November 28, 2024 16:57
@smelc smelc force-pushed the smelc/cl/implement-query-proposals branch from 29eae83 to 89d2ac8 Compare December 10, 2024 08:50
@smelc smelc changed the base branch from master to smelc/update-api-to-10.4.0.0 December 10, 2024 08:52
@smelc smelc force-pushed the smelc/cl/implement-query-proposals branch 2 times, most recently from 0ff8372 to bcdbaeb Compare December 10, 2024 08:59
@smelc smelc marked this pull request as ready for review December 10, 2024 09:01
@smelc smelc force-pushed the smelc/cl/implement-query-proposals branch from bcdbaeb to 53a66bd Compare December 10, 2024 09:05
Base automatically changed from smelc/update-api-to-10.4.0.0 to master December 10, 2024 13:05
@smelc smelc force-pushed the smelc/cl/implement-query-proposals branch 2 times, most recently from 2050f74 to a89c623 Compare December 10, 2024 14:39
@smelc smelc removed the next-update Needs a dependency to be updated to be merged label Dec 10, 2024
@smelc smelc force-pushed the smelc/cl/implement-query-proposals branch from a89c623 to 69def06 Compare December 10, 2024 17:15
Copy link
Contributor

@palas palas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I cannot find any issues by looking at the code.

It would be good to also test:

  • Querying for more than one governance action ids at the same time
  • Query using the --all-proposals flag
  • Checking the result is the same as for cardano-cli conway query gov-state | jq .proposals as in the acceptance criteria.

I've also noticed that it is not clear in the documentation generated that you can actually query for several action ids. But I've checked and it is done the same as for other commands, so this PR is fine.

@smelc
Copy link
Contributor Author

smelc commented Dec 11, 2024

Querying for more than one governance action ids at the same time
Query using the --all-proposals flag
Checking the result is the same as for cardano-cli conway query gov-state | jq .proposals as in the #903.

@palas> Yep we actually did all of this manually with @CarlosLopezDeLara in cardano-testnet 👌

@smelc smelc force-pushed the smelc/cl/implement-query-proposals branch from 69def06 to 54f4a6d Compare December 11, 2024 08:59
@smelc smelc enabled auto-merge December 11, 2024 09:00
@smelc smelc added this pull request to the merge queue Dec 11, 2024
Merged via the queue into master with commit 3c0af7a Dec 11, 2024
26 checks passed
@smelc smelc deleted the smelc/cl/implement-query-proposals branch December 11, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] - Implement conway query proposals
2 participants