Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Add a Conway parameter update governance tests #1778

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

sgillespie
Copy link
Contributor

@sgillespie sgillespie commented Jul 19, 2024

Description

This should complete #1572. Adds the following tests:

  • protocol parameter change
  • hard fork initiation

I've also attempted to make writing governance tests easier by factoring out some of the common boilerplate.

Checklist

  • Commit sequence broadly makes sense
  • Commits have useful messages
  • New tests are added if needed and existing tests are updated
  • Any changes are noted in the changelog
  • Code is formatted with fourmolu on version 0.10.1.0 (which can be run with scripts/fourmolize.sh)
  • Self-reviewed the diff

Migrations

  • The pr causes a breaking change of type a,b or c
  • If there is a breaking change, the pr includes a database migration and/or a fix process for old values, so that upgrade is possible
  • Resyncing and running the migrations provided will result in the same database semantically

If there is a breaking change, especially a big one, please add a justification here. Please elaborate
more what the migration achieves, what it cannot achieve or why a migration is not possible.

@sgillespie sgillespie changed the title test: Add a Conway parameter change governance test Test: Add a Conway parameter update governance tests Jul 22, 2024
@sgillespie sgillespie marked this pull request as ready for review July 22, 2024 18:54
@sgillespie sgillespie requested a review from a team as a code owner July 22, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants