add-from-github requires listing all subdirs

[michaelpj]

~/projects/iohk/cardano-haskell-packages mpj/plutus-and-ledger-releases ⇡1 ❯ ./scripts/add-from-github.sh -v 0.1.1.0 https://github.com/input-output-hk/cardano-ledger 26849193788a38479367799cbb249699ac952bab                                                                                                      ✘ INT
Work directory is /tmp/tmp.PawlrJcTic
/tmp/tmp.PawlrJcTic ~/projects/iohk/cardano-haskell-packages
Fetching https://github.com/input-output-hk/cardano-ledger at revision 26849193788a38479367799cbb249699ac952bab
~/projects/iohk/cardano-haskell-packages
awk: fatal: cannot open file `/tmp/tmp.PawlrJcTic//*.cabal' for reading: No such file or directory

[michaelpj]

I guess you have to pass subdirs? Would be nice if it could get it from cabal.project

[andreabedini]

Yes, we have to pass subdirs. I always preferred explicit to implicit (also parsing cabal.project is not trivial, one might as well find all the cabal files).

[JaredCorduan]

It would be nice if the script checked to see if the user passed at least one subdir to the script, and returned a helpful error message if not.