cardano-testnet: better API for using custom genesis files #5715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smelc
force-pushed
the
smelc/enhance-custom-genesis-API
branch
from
736347c to
015670c
Compare
carbolymer
reviewed
Mar 14, 2024
carbolymer
reviewed
Mar 14, 2024
carbolymer
reviewed
Mar 14, 2024
carbolymer
approved these changes
Mar 14, 2024
smelc
force-pushed
the
smelc/enhance-custom-genesis-API
branch
from
c3a1b66 to
0c22b6d
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Right now, if you want to create a testnet using custom genesis files, it's cumbersome, because you need to provide a shelley genesis file with the right timestamp. This is clunky.
The same goes for providing the default alonzo genesis file, obtaining it is clunky.
What this PR does
This PR provides new functions to obtain the shelley and alonzo genesis files that are not clunky, because they deal with clunkiness of obtaining those files within the test monad. So from within tests, those functions are handy.
This new API will be used in upcoming PRs of mine.
Checklist