simplify the LSQ server test #937
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For example, I removed the replication of the Immutable/VolatileTip acquire messages, since the test is so simple that the number of those is currently irrelevant---it's misleading to replicate them, as if that was already expected to matter.
amesgen
reviewed
Feb 5, 2024
| @@ -144,7 +148,7 @@ checkOutcome k chain = conjoin . map (uncurry checkResult) | |||
| | otherwise | |||
| -> tabulate "Acquired" ["AcquireFailurePointNotOnChain"] $ property True | |||
| Left AcquireFailurePointTooOld | |||
| | pointSlot pt >= immutableSlot | |||
| | pointSlot pt >= immutableSlot -- TODO what if the immtip is a multi-leader slot? | |||
There was a problem hiding this comment.
When we ask for a point with the same slot as the immutable tip, but with a different hash, we get a AcquireFailurePointNotOnChain, right?
Comment on lines
+91
to
+92
| -- A random sequence of targets: one for each block in the tree and also a | ||
| -- random number of immtip/voltip queries |
There was a problem hiding this comment.
A random sequence of targets: one for each block in the tree and also a random number of immtip/voltip queries
Isn't the change that is explained in the PR description exactly about removing the fact that there is a random number of voltip queries, instead just using one?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example, I removed the replication of the Immutable/VolatileTip acquire messages, since the test is so simple that the number of those is currently irrelevant---it's misleading to replicate them, as if that was already expected to matter.