Add get my data by name, and fix unsubscribe #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyantrim
changed the title
andyantrim
force-pushed
the
ab-add-data-by-name
branch
from
e918d2f
to
a645720
Compare
vtermanis
reviewed
Oct 24, 2024
vtermanis
reviewed
Oct 24, 2024
nyx_client/nyx_client/client.py
Outdated
| @@ -517,6 +518,30 @@ def get_data( | |||
| for resp in resps | |||
| ] | |||
|
|
|||
| def get_my_data_by_name(self, name: str) -> Data: | |||
| """Retrieve a data based on its unique name. | |||
There was a problem hiding this comment.
- "Retrieve my own data"?
- The name only unique for that organisation
Ah ok - I see you have that below but I think it might be important enough to state in the summary line 🤔
vtermanis
reviewed
Oct 24, 2024
vtermanis
reviewed
Oct 24, 2024
nyx_client/nyx_client/client.py
Outdated
| name: The data unique name. | ||
|
|
||
| Returns: | ||
| The `Data` instance identified with the provided name. |
vtermanis
approved these changes
Oct 24, 2024
andyantrim
force-pushed
the
ab-add-data-by-name
branch
from
0e9c1a8
to
5ac784b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.