Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from CRA to Vite #326

Merged
merged 43 commits into from
Dec 19, 2024
Merged

Migrate from CRA to Vite #326

merged 43 commits into from
Dec 19, 2024

Conversation

IraSoro
Copy link
Owner

@IraSoro IraSoro commented Dec 13, 2024

Close #325

@IraSoro IraSoro added this to the v2.5.1 milestone Dec 13, 2024
@IraSoro IraSoro requested a review from imblowfish December 13, 2024 19:39
@IraSoro IraSoro self-assigned this Dec 13, 2024
Copy link

vercel bot commented Dec 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
peri ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 19, 2024 11:36am

@imblowfish
Copy link
Collaborator

Everything looks fine, but I made several changes, @IraSoro please review:

  • Added Node.js v22 as the latest LTS in the ci.yml's strategy
  • Removed unused workbox dependencies, because vite's PWA works differently

@IraSoro IraSoro merged commit 0d4e80e into master Dec 19, 2024
4 checks passed
@IraSoro IraSoro deleted the 325-migrate-to-vite branch December 19, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Migrate from create-react-app to Vite
2 participants