Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Starknet signer #3

Merged
merged 9 commits into from
Oct 7, 2024
Merged

Starknet signer #3

merged 9 commits into from
Oct 7, 2024

Conversation

codeWhizperer
Copy link
Contributor

No description provided.

JesseTheRobot
JesseTheRobot reviewed Sep 26, 2024
View reviewed changes
src/ar-data-base.ts Outdated Show resolved Hide resolved
@JesseTheRobot JesseTheRobot mentioned this pull request Sep 30, 2024
Closed
@JesseTheRobot JesseTheRobot changed the title Sign verify Starknet signer Oct 7, 2024
JesseTheRobot
JesseTheRobot requested changes Oct 7, 2024
View reviewed changes
Copy link
Member

@JesseTheRobot JesseTheRobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The core logic is sound, just a few tweaks before I think it's ready

src/signing/chains/StarknetSigner.ts Outdated Show resolved Hide resolved
src/signing/chains/StarknetSigner.ts Outdated Show resolved Hide resolved
yarn.lock Outdated Show resolved Hide resolved
src/__tests__/starknet.test.ts Show resolved Hide resolved
@Darlington02
Copy link
Contributor

Hi @JesseTheRobot, I've fixed all the requested changes

@JesseTheRobot JesseTheRobot self-requested a review October 7, 2024 21:53
JesseTheRobot
JesseTheRobot approved these changes Oct 7, 2024
View reviewed changes
Copy link
Member

@JesseTheRobot JesseTheRobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JesseTheRobot JesseTheRobot merged commit f06294c into Irys-xyz:master Oct 7, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Darlington02 Darlington02 Darlington02 left review comments

@JesseTheRobot JesseTheRobot JesseTheRobot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@codeWhizperer @Darlington02 @JesseTheRobot