Starknet #17
Starknet #17
Conversation
| }; | ||
|
|
||
| // Update the NodeIrysConfig type to include TokenOptions for tokenOpts | ||
| interface NodeIrysConfig<T> { |
There was a problem hiding this comment.
why is there an unused generic here?
| const addressLength = 32; | ||
|
|
||
| // Get the returned public key and convert to a buffer | ||
| const returnedPubKey = await this.getAccountPublicKey(); |
There was a problem hiding this comment.
this function should be in getPublicKey, the result from getPublicKey should be able to be passed into ownerToAddress to go from publicKey -> Address, to mimic what happens when we take the publicKey from a transaction when verifying it
There was a problem hiding this comment.
I thought the conclusion was to have the ownerToAddress compare the public from the signer instance with the publickey returned from getAccountPublickey and if it is equal , then we can return the address
| } | ||
|
|
||
| getPublicKey(): string | Buffer { | ||
| return this.signer.publicKey; |
There was a problem hiding this comment.
I don't think this method is correct given our compound public key definition
There was a problem hiding this comment.
The method above return the publickey value directly from the Signer instance
No description provided.