Add Config Override Inspector (COI). #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aOelschlager
approved these changes
Nov 15, 2023
There was a problem hiding this comment.
I used this to test the two COI prs (Islandora/openseadragon#57, Islandora/islandora#986)
It works!
Needs to pull in the newest commits in main and it's ready to go!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#112
This PR causes the Starter Site to have Config Override Inspector installed.
It configures the module to
secretIt relies on the module forms including a
configkey which most don't. There are PRs for islandora and openseadragon to mark up the appropriate form elements, but some values we (site template) override are for search_api and matomo and they're not COI-compatible. So this will (as of now) have only a partial effect.@Islandora-Devops/committers