Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CrayFits as part of Crayfish #178

Merged
merged 49 commits into from
Nov 1, 2023
Merged

CrayFits as part of Crayfish #178

merged 49 commits into from
Nov 1, 2023

Conversation

rosiel
Copy link
Member

@rosiel rosiel commented Oct 19, 2023

GitHub Issue: discussed in Tech Call.

What does this Pull Request do?

Merges the CrayFits code as a directory within Crayfish. Keeps all git history.

What's new?

CrayFits code

  • Re-licenses it as MIT (formerly GPL, probably because we thought all Islandora code had to be)
  • Does this change require documentation to be updated? - hardly, though it does permit some implementation code to be simplified
  • Does this change add any new dependencies? Possibly - though each microservice has its own requirements. See composer.json.
  • Does this change require any other modifications to be made to the repository (i.e. Regeneration activity, etc.)? No
  • Could this change impact execution of existing code? no.

How should this be tested?

  • Set up a site to use Crayfits from Crayfish (this could be done in buildkit or on a whole VM if anyone's still setting up that way)
  • Note that you still need the separate FITS webservice
  • You should be able to generate FITS derivatives.

Additional Notes:

Any additional information that you think would be helpful when reviewing this PR.

Interested parties

Tag (@ mention) interested parties or, if unsure, @Islandora/8-x-committers

Alan Stanley and others added 30 commits April 15, 2019 14:07
first commit
f9ce5a6
Accepts header
797ab1e
Changed Content-type
1a25f35
Add .htaccess file
55bc029
Added environmental variable
dd993c0
Added dependencies
d0f24a4
Refactor pre migration
ba0dfc2
Added vendor and packages to git files
f08ca8b
added vendor
a1f9c95
Cleaned cruft
68ddb2f
removed unused dependencies
b2b0cf3
cleared cruft
caff345
reverted ignore
a14606a
cleared vendor files
a6eaadb
Added logger
dbec22c
Force UTF 8
5c5ddcb
added monolog
ab4e8fe
Changed path
a07b847
changed path
92fb1b2
merged conflicts
3364f03
Added health message.
8f280a9
Adjusted phpdocs
2172871
@dependabot
Bump symfony/cache from 4.2.11 to 4.3.9
8331758 
Bumps [symfony/cache](https://github.com/symfony/cache) from 4.2.11 to 4.3.9.
- [Release notes](https://github.com/symfony/cache/releases)
- [Changelog](https://github.com/symfony/cache/blob/master/CHANGELOG.md)
- [Commits](symfony/cache@v4.2.11...v4.3.9)

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
Bump symfony/http-foundation from 4.2.11 to 4.4.1
e7dac57 
Bumps [symfony/http-foundation](https://github.com/symfony/http-foundation) from 4.2.11 to 4.4.1.
- [Release notes](https://github.com/symfony/http-foundation/releases)
- [Changelog](https://github.com/symfony/http-foundation/blob/master/CHANGELOG.md)
- [Commits](symfony/http-foundation@v4.2.11...v4.4.1)

Signed-off-by: dependabot[bot] <support@github.com>
@ajstanley
Merge pull request Islandora#1 from roblib/dependabot/composer/symfon…
4578f04 
…y/cache-4.3.9

Bump symfony/cache from 4.2.11 to 4.3.9
@ajstanley
Merge pull request Islandora#2 from roblib/dependabot/composer/symfon…
6c19ec2 
…y/http-foundation-4.4.1

Bump symfony/http-foundation from 4.2.11 to 4.4.1
added logging
2e3fe2e
@ajstanley
Update FitsController.php
8bbe270 
Typo
@ajstanley
Moved authorization
2a8965d
cleanup
ad2d772
dependabot bot and others added 18 commits March 31, 2020 00:29
@dependabot
Bump symfony/http-foundation from 4.4.1 to 4.4.7
88da26c 
Bumps [symfony/http-foundation](https://github.com/symfony/http-foundation) from 4.4.1 to 4.4.7.
- [Release notes](https://github.com/symfony/http-foundation/releases)
- [Changelog](https://github.com/symfony/http-foundation/blob/master/CHANGELOG.md)
- [Commits](symfony/http-foundation@v4.4.1...v4.4.7)

Signed-off-by: dependabot[bot] <support@github.com>
@ajstanley
Merge pull request Islandora#3 from roblib/dependabot/composer/symfon…
70fb12c 
…y/http-foundation-4.4.7

Bump symfony/http-foundation from 4.4.1 to 4.4.7
@ajstanley
Create LICENSE
4e0faeb
@nigelgbanks
Update dependencies to support using Composer 2.0 for installation.
6e95f2f
@ajstanley
Merge pull request Islandora#4 from nigelgbanks/composer-2-support
c81bf83 
Update dependencies to support using Composer 2.0 for installation.
@dependabot
Bump guzzlehttp/psr7 from 1.7.0 to 1.8.5
b903d11 
Bumps [guzzlehttp/psr7](https://github.com/guzzle/psr7) from 1.7.0 to 1.8.5.
- [Release notes](https://github.com/guzzle/psr7/releases)
- [Changelog](https://github.com/guzzle/psr7/blob/1.8.5/CHANGELOG.md)
- [Commits](guzzle/psr7@1.7.0...1.8.5)

---
updated-dependencies:
- dependency-name: guzzlehttp/psr7
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
@rosiel
Merge pull request Islandora#6 from roblib/dependabot/composer/guzzle…
eaaa104 
…http/psr7-1.8.5

Bump guzzlehttp/psr7 from 1.7.0 to 1.8.5
@dependabot
Bump guzzlehttp/guzzle from 6.5.5 to 6.5.8
61e89b2 
Bumps [guzzlehttp/guzzle](https://github.com/guzzle/guzzle) from 6.5.5 to 6.5.8.
- [Release notes](https://github.com/guzzle/guzzle/releases)
- [Changelog](https://github.com/guzzle/guzzle/blob/6.5.8/CHANGELOG.md)
- [Commits](guzzle/guzzle@6.5.5...6.5.8)

---
updated-dependencies:
- dependency-name: guzzlehttp/guzzle
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@rosiel
Update composer.json
5d9f5f0
@rosiel
Merge pull request Islandora#9 from roblib/dependabot/composer/guzzle…
b37e711 
…http/guzzle-6.5.8

Bump guzzlehttp/guzzle from 6.5.5 to 6.5.8
@nigelgbanks
Attempt to get working under PHP 8.1
4c37211 
- Removed lock file
- Updated test matrix

For reasons behind removing the lock file see:
https://islandora.slack.com/archives/CM5PPAV28/p1659631615201049
Islandora/documentation#1908 (Removal approved)

Instead we'll provide lock files in isle and ansible deployments.
@rosiel
Add README.
314dfde
@alxp
Merge pull request Islandora#10 from nigelgbanks/upgrade-php
89f8229
@rosiel
Merge pull request Islandora#11 from roblib/README
2a14ebf 
Add README.
@rosiel
Prepare for merge with Crayfish.
63abd9d
@rosiel
Merge CrayFits into Crayfish.
8da7fca
@rosiel
Add test script.
fa38ca5
@rosiel
Remove until Crayfits has tests
97714e2
@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!.

@rosiel rosiel self-assigned this Oct 25, 2023
@rosiel
Copy link
Member Author

rosiel commented Oct 25, 2023

Update readme.

@seth-shaw-asu seth-shaw-asu self-requested a review November 1, 2023 17:49
seth-shaw-asu
seth-shaw-asu approved these changes Nov 1, 2023
View reviewed changes
Copy link
Member

@seth-shaw-asu seth-shaw-asu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as advertised.

@seth-shaw-asu seth-shaw-asu merged commit 6ba190c into Islandora:4.x Nov 1, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seth-shaw-asu seth-shaw-asu seth-shaw-asu approved these changes

Assignees

@rosiel rosiel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rosiel @seth-shaw-asu @ajstanley @nigelgbanks @alxp