Add SVG icons to field types. #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks nice. I'm wondering if the Authority Link would be better as a link superimposed over the Selection list icon; since it is essentially a link field combined with a selection list field. |
|
I could do that with Typed Relation, too. |
|
New screenshot: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue: none
Other Relevant Links (Google Groups discussion, related pull requests,
Release pull requests, etc.): Previously mentioned in a Tech Call.
What does this Pull Request do?
Make the Add Field interface pretty for these field types.
What's new?
Use the new Drupal 10.2 Field Type API -- this is why it's draft, until we can drop 10.1 - to define our Typed Relation as a category. Now it works like the Reference field, where you select a category then select a sub-type.
Added three SVG icons for our fields, based off the icons of the field types they're based on.
Added a library to add those CSS classes
Did a hook form alter to add our CSS library to the form. (I declined to use the Form Alter As Plugin module, though it seems cool.)
Does this change require documentation to be updated? - Maybe screenshots, when we get the rest of our weird fields prettified.
Does this change add any new dependencies? no
Does this change require any other modifications to be made to the repository
(i.e. Regeneration activity, etc.)? no
Could this change impact execution of existing code? no
How should this be tested?
Additional Notes:
Any additional information that you think would be helpful when reviewing this
PR.
Interested parties
Tag (@ mention) interested parties or, if unsure, @Islandora/committers