Remove deprecated prophecy calls and MimeTypeGuesserInterface. #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue: Islandora/documentation#2235
Release pull requests, etc.) Update compatibility to include Drupal 10. #49
What does this Pull Request do?
Removes deprecated calls to prophesize() and uses of the deprecated MimeTypeGuesser. Also declares D10 compatibility.
What's new?
This should make it work in Drupal 10 as it does in Drupal 9.
(i.e. Regeneration activity, etc.)? no
How should this be tested?
Spin it up on Drupal 10 and put a valid Cantaloupe URL in the OpenSeadragon settings. Place a block and feed it a manifest (since the IIIF submodule isn't ready yet) throw a demo manifest URI in the block like https://digital.library.villanova.edu/Item/vudl:92879/Manifest . Verify it shows the content, and no messages in the logs.
Additional Notes:
The tests ran (in a D9 environment) just fine. CI will tell us about Drupal 10.
Interested parties
Tag (@ mention) interested parties or, if unsure, @Islandora/committers