[MOB-6612] Align method, class, protocol names with android #663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anlinguist
changed the title
Ayyanchira
approved these changes
Jul 27, 2023
|
|
||
| import Foundation | ||
|
|
||
| @objc public protocol IterableEmbeddedManagerProtocol { |
There was a problem hiding this comment.
Here the class protocol's name ends with Protocol. but in IterableEmbeddedMessagingUpdateDelegate, it ends withDelegate. I think (have to revisit the codebase to see whats been followed) Protocol objects can be called Delegates but the class itself can remain as Protocol. Will have to reconsider renaming this for consistency.
| @@ -4,7 +4,7 @@ | |||
|
|
|||
| import Foundation | |||
|
|
|||
| @objc public protocol IterableEmbeddedMessagingUpdateDelegate { | |||
| @objc public protocol IterableEmbeddedUpdateDelegate { | |||
There was a problem hiding this comment.
Not for this PR but - Will making this protocol method or both methods a part of IterableEmbeddedManagerProtocol be useful?? What do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔹 Jira Ticket(s)
✏️ Description
This PR updates the SDK to align names with android.