Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MOB-6648] update get messages to pull messages from placement #665

Merged
merged 3 commits into from
Aug 10, 2023
Merged

[MOB-6648] update get messages to pull messages from placement #665

merged 3 commits into from
Aug 10, 2023

Conversation

evantk91
Copy link
Collaborator

@evantk91 evantk91 commented Aug 1, 2023 •
edited by jira bot
Loading

🔹 Jira Ticket(s)

✏️ Description

This pull request updates the syncMessages function to pull messages from the placement object in the payload.

@evantk91 evantk91 changed the title [mob 6648] update get messages to pull messages from placement [MOB-6648] update get messages to pull messages from placement Aug 1, 2023
@anlinguist
Copy link
Collaborator

  1. When calling getMessages(for placementId:), we need to make placementId a non-optional Int because server is returning placementId as a number type and without a placementId passed in, the alternative method getMessages() should be called.
  2. We need to update tests.

Fixed in last commit.

Ayyanchira
Ayyanchira approved these changes Aug 7, 2023
View reviewed changes
Copy link
Member

@Ayyanchira Ayyanchira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nit pick comments left

swift-sdk/Internal/EmbeddedMessagingSerialization.swift Show resolved Hide resolved
swift-sdk/Internal/IterableEmbeddedManager.swift Show resolved Hide resolved
swift-sdk/Internal/IterableEmbeddedManager.swift Show resolved Hide resolved
swift-sdk/IterableEmbeddedMessage.swift Show resolved Hide resolved
anlinguist
anlinguist approved these changes Aug 8, 2023
View reviewed changes
Copy link
Collaborator

@anlinguist anlinguist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@evantk91 evantk91 merged commit ae07c49 into embedded-messaging Aug 10, 2023
2 checks passed
@evantk91 evantk91 deleted the anelson/mob-6648-update-getmessages branch August 10, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ayyanchira Ayyanchira Ayyanchira approved these changes

@anlinguist anlinguist anlinguist approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@evantk91 @anlinguist @Ayyanchira