Preventing Core Data exceptions when no stores are attached #816
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR prevents a crash which occurs when Core Data's persistent store fails to load. This can happen for several reasons: the database could be corrupted, the disk might be full, or from a bad migration. This also might occur when the app wakes up in the background and the persistent store didn't load in time.
Crash
The crash originates from
IterableTaskScheduler.deleteAllTasks()
which callstry persistenceContext.save()
which throws:How to Fix
When using
NSPersistentContainer
it's important to handle any errors fromloadPersistentStores:
since they're recoverable. If you ignore this error, then Core Data throws an Objective-C exception which cannot be handled in Swift when you try to save.