[MOB-9974] fix event replay from visitor to known user #845
Conversation
| func syncNonSyncedEvents() | ||
| func syncEvents() |
There was a problem hiding this comment.
Question on why are we deciding to stop using the syncNonSyncedEvents method that just adds a delay in execution of the syncEvents method?
On the InternalIterableAPI method attemptAndProcessMerge we can easily still call syncNonSyncedEvents instead right? Is there any reason why we want to use the syncEvents method directly?
There was a problem hiding this comment.
Calling that function was clearing the local storage for some odd reason
There was a problem hiding this comment.
Hm, I see. Maybe there's a race condition issue then?
| if(config.enableAnonTracking) { | ||
| if(email != nil) { | ||
| attemptAndProcessMerge(merge: merge ?? true, replay: replay ?? true, destinationUser: email, isEmail: true, failureHandler: failureHandler) | ||
| } | ||
| self.localStorage.userIdAnnon = nil | ||
| } | ||
|
|
There was a problem hiding this comment.
| if(config.enableAnonTracking) { | |
| if(email != nil) { | |
| attemptAndProcessMerge(merge: merge ?? true, replay: replay ?? true, destinationUser: email, isEmail: true, failureHandler: failureHandler) | |
| } | |
| self.localStorage.userIdAnnon = nil | |
| } | |
| if config.enableAnonTracking, let email = email { | |
| attemptAndProcessMerge( | |
| merge: merge ?? true, | |
| replay: replay ?? true, | |
| destinationUser: email, | |
| isEmail: true, | |
| failureHandler: failureHandler | |
| ) | |
| self.localStorage.userIdAnnon = nil | |
| } |
There was a problem hiding this comment.
Just code style suggestion. It helps reducing the nesting and makes the code easier to read!
Also, in Swift you don't need to add the ( ) on if statements.
| if(config.enableAnonTracking) { | ||
| if(userId != nil && userId != localStorage.userIdAnnon) { | ||
| attemptAndProcessMerge(merge: merge ?? true, replay: replay ?? true, destinationUser: userId, isEmail: false, failureHandler: failureHandler) | ||
| } | ||
|
|
||
| if(!isAnon) { | ||
| self.localStorage.userIdAnnon = nil | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
| if(config.enableAnonTracking) { | |
| if(userId != nil && userId != localStorage.userIdAnnon) { | |
| attemptAndProcessMerge(merge: merge ?? true, replay: replay ?? true, destinationUser: userId, isEmail: false, failureHandler: failureHandler) | |
| } | |
| if(!isAnon) { | |
| self.localStorage.userIdAnnon = nil | |
| } | |
| } | |
| if config.enableAnonTracking { | |
| if let userId = userId, userId != localStorage.userIdAnnon { | |
| attemptAndProcessMerge( | |
| merge: merge ?? true, | |
| replay: replay ?? true, | |
| destinationUser: userId, | |
| isEmail: false, | |
| failureHandler: failureHandler | |
| ) | |
| } | |
| if !isAnon { | |
| localStorage.userIdAnnon = nil | |
| } | |
| } | |
🔹 Jira Ticket(s)
✏️ Description