Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature-initial-config-addClassesFolder #25

Merged

Conversation

IvonneBenitesRodriguez
Copy link
Owner

About this project

In this part of the project, I added a folder named classes where files named main.rb and item.rb
are stored.

For it:

  • I created a featured branch named : feature-initial-config-addClassesFolder. ✅
  • I created a folder named classes and stored inside files mentioned above. ✅
  • I updated file like .rubocop.yml and Gemfile. ✅
  • I added file named tests.yml inside .github folder. ✅
  • Linters were passed. ✅

Goal:

The goal is to understand the importance of setting up very well all our files before starting our project.

Copy link
Collaborator

@gilberthappi gilberthappi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @IvonneBenitesRodriguez

Your project is complete! There is nothing else to say other than... it's time to merge it

Congratulations!

200

Highlights

✅ Linters are passing
✅ Good commit history
✅ Excellent work implementing tests! 💯

@IvonneBenitesRodriguez IvonneBenitesRodriguez merged commit f880a50 into development Nov 29, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants