RubyCapstoneFinalProject-PullRequest #39
Conversation
…nfig Feature initial config
…nfig-addClassesFolder feature-initial-config-addClassesFolder
Create-Game-class-&&-Create-Author-class-add-methods-Task1andTask2
Create-a-Book-class-Task1-Task2
Game author test
add option for games and author
test-book-PullRequest
Preserve data from gaame and author
book-label-refactor-PullRequest
f-preserved-PullRequest
Add music album
Create a schema.sql file with tables
add-Game-and-Author-Schema-PullRequest
Add test files and schema file
There was a problem hiding this comment.
Hi @IvonneBenitesRodriguez @gilberthappi 👋,
Your project is complete! There is nothing else to say other than... it's time to merge it 
Congratulations! 🎉
Highlights
- No linter errors 👍
- Well-written PR 👍
- Good looking readme 👍
- Professional video presentation 👍
Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
About this project
This Project is about building a console app named "Catalog of My Things".
This app provides users the functionality to manage collections of their possessions, including books, music albums, movies, and games. All Data is stored in JSON files and a database with a table structure analogous to the program's class structure is created.
Main Features:
Logic each class is created in a separate rb file according to the UML diagram.
User Interface with the main.rb file to provide the user a list of options to perform, provide the users several options to choose, ask for parameters the option, and a way to exit the app.
Database a file named schema.sql file is created with properties and associations.
We have implemented methods like add_item method in all classes, can_be_archived?( ), between others.
Unit tests have been added for all implemented tests.
Linters were passed.
We respected the Gitflow.
We followed the documentation in a professional way.
We followed the Best Practices of Ruby.
Please visit our presentation video here:
https://drive.google.com/file/d/1h5R-_EZiN1wqvJ5DhnEHGD5NOdGccGfx/view
Thank you for your attention,