Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Futures on the RenderLoops #279

Merged
merged 5 commits into from
Oct 30, 2022
Merged

Use Futures on the RenderLoops #279

merged 5 commits into from
Oct 30, 2022

Conversation

JD557
Copy link
Owner

@JD557 JD557 commented Oct 30, 2022

Uses Future's on the Render Loop implementations so that:

  • The behavior of RenderLoop is consistent across platforms (previously JS would return immediately while other implementations would block)
  • Futures work in Scala Native (the render loop is written so that SNs execution context can run tasks between frames)

I ran some quick benchmarks and didn't see any performance differences in Scala Native (the other implementations are pretty much the same)

Related to #19 and #224

@JD557 JD557 added this to the 0.5.0 milestone Oct 30, 2022
@JD557 JD557 merged commit 2abee2e into experimental-0.5 Oct 30, 2022
@JD557 JD557 deleted the async-runloop branch October 30, 2022 17:00
@JD557 JD557 mentioned this pull request Oct 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.5.0
Development

Successfully merging this pull request may close these issues.
1 participant
@JD557