You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I was working with a student and noticed a difference between the JETSCAPE and XSCAPE final state hadron writer ascii output. Namely, it adds these two lines at the end of the ascii file:
I think this change is a regression: the event weight and pt hat can change event-by-event, so writing the value from the last event at the end of the file could be misleading. It also further changes the convention for the pt hat label (pt_hat vs pt-hat). Concretely, it looks like:
... particle record of last event
...
# sigmaGen 2.16335 sigmaErr 0.00339685 weight 1 pT-Hat 9.08961
Note that this change also breaks the parser that we often use for analysis (code is here ). I can of course update the parser, but it's unclear to me what is the benefit of the new convention. Is there some benefit for XSCAPE that is not needed for JETSCAPE? If not, I would propose reverting to a consistent approach between the two (i.e. only writing the sigmaGen and sigmaErr). Thanks!
The text was updated successfully, but these errors were encountered:
I was working with a student and noticed a difference between the JETSCAPE and XSCAPE final state hadron writer ascii output. Namely, it adds these two lines at the end of the ascii file:
X-SCAPE/src/framework/JetScapeWriterFinalStateStream.cc
Lines 153 to 154 in 4dd1dbc
I think this change is a regression: the event weight and pt hat can change event-by-event, so writing the value from the last event at the end of the file could be misleading. It also further changes the convention for the pt hat label (pt_hat vs pt-hat). Concretely, it looks like:
Note that this change also breaks the parser that we often use for analysis (code is here ). I can of course update the parser, but it's unclear to me what is the benefit of the new convention. Is there some benefit for XSCAPE that is not needed for JETSCAPE? If not, I would propose reverting to a consistent approach between the two (i.e. only writing the sigmaGen and sigmaErr). Thanks!
The text was updated successfully, but these errors were encountered: