Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Differece between JETSCAPE and XSCAPE final state hadron writer #33

Open
raymondEhlers opened this issue Jun 13, 2024 · 0 comments
Open

Comments

@raymondEhlers
Copy link
Contributor

I was working with a student and noticed a difference between the JETSCAPE and XSCAPE final state hadron writer ascii output. Namely, it adds these two lines at the end of the ascii file:

<< "weight\t" << GetHeader().GetEventWeight() << "\t"
<< "pT-Hat\t" << GetHeader().GetPtHat() << "\n";

I think this change is a regression: the event weight and pt hat can change event-by-event, so writing the value from the last event at the end of the file could be misleading. It also further changes the convention for the pt hat label (pt_hat vs pt-hat). Concretely, it looks like:

... particle record of last event
...
#       sigmaGen        2.16335 sigmaErr        0.00339685      weight  1       pT-Hat  9.08961

Note that this change also breaks the parser that we often use for analysis (code is here ). I can of course update the parser, but it's unclear to me what is the benefit of the new convention. Is there some benefit for XSCAPE that is not needed for JETSCAPE? If not, I would propose reverting to a consistent approach between the two (i.e. only writing the sigmaGen and sigmaErr). Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant