Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request to add diffDoesNotAdd or similar parameter #138

Open
Yadunund opened this issue Jul 1, 2024 · 2 comments
Open

Request to add diffDoesNotAdd or similar parameter #138

Yadunund opened this issue Jul 1, 2024 · 2 comments
Labels
enhancement New feature or request
Milestone

Comments

@Yadunund
Copy link

Yadunund commented Jul 1, 2024

If a PR is opened which removes the usage of a string and at the same time wants to include a new Github action to ensure instances of the string are not present in future PRs, relying ondiffDoesNotContain parameter will lead to an action failure since the current diff includes deletions of the configured string. Hence, a diffDoesNotAdd parameter that only checks the diff additions for instances of the configured string would be great!

@JJ JJ added the enhancement New feature or request label Jul 2, 2024
@JJ
Copy link
Owner

JJ commented Jul 2, 2024

Thanks for opening the issue. This is going to need a certain amount of internal refactoring, so I set it for future releases.

@JJ JJ added this to the v15 milestone Jul 2, 2024
@JJ
Copy link
Owner

JJ commented Jul 2, 2024

Hum, I'm checking parse-diff code and that's not an information that's directly in the data parsed from the diff... Best effort here would be to check if the word is in the lines added, but if it was already there, it will make no difference, it will fail anyway. I can check if it's in the lines added and not in the existing lines, however...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants