Fixing Notes Security (#26)

* Fixing Notes Security

* 1 issue was detected with this workflow: Please specify an on.push hook so that Code Scanning can compare pull requests against the state of the base branch. FIX

.eslintrc.js

@@ -17,10 +17,14 @@ module.exports = {
       "jsx-a11y",
     ],
     rules: {
+      "@typescript-eslint/no-useless-escape": 0,
       semi: [2, "never"],
-      strict: 0,
       "react-hooks/rules-of-hooks": "error",
-      "react-hooks/exhaustive-deps": "warn"
+      "react-hooks/exhaustive-deps": "warn",
+      "@typescript-eslint/no-unused-vars": 0,
+      strict: 1,
+      "noUnusedLocals": true,
+      "noUnusedParameters": true
     },
     settings: {
       react: {

.github/workflows/action-analyser.yml

@@ -1,6 +1,8 @@
 name: Github Action Security Analysis
 
 on:
+  push:
+    branches: [ main ]
   pull_request:
     branches: [ main ]
     paths-ignore:

README.md

@@ -3,13 +3,13 @@
 An action that simply sends a mail to multiple recipients.
 
 Some features:
+
 - plain text body
 - HTML body
 - multipart body (plain text + HTML)
 - Markdown to HTML converting
 - file attachments (supports globbing)
 
-
 ## Usage
 
 ```yaml
@@ -61,6 +61,7 @@ Some features:
 Gmail security settings may cause this Action to fail. This failure may involve a message in the GitHub Actions details about access being denied and an email from Google to the email account being used about a sign-in being blocked and why.
 
 Changes in Gmail settings may be necessary to get this action to work.
+
 1. Google treats this method of using email as a "Less Secure App". However, "Less Secure Apps" can be enabled in [Google profile settings](https://myaccount.google.com/lesssecureapps).
 2. IMAP needs to be enabled in Gmail settings as described [here](https://support.google.com/mail/answer/7126229?hl=en).
 3. If the Gmail account you're trying to use in this Action is already 2FA (Two Factor Authentication) enabled, the 2FA password will need to be provided as well, which isn't included in the default template.
@@ -72,6 +73,6 @@ Users who have had problems have reported success by doing each of these three s
 The parameters `username` and `password` are set as optional to support self-hosted runners access to on-premise infrastructure. If
 you are accessing public email servers make sure you provide a username/password authentication through [GitHub Secrets](https://docs.github.com/en/actions/reference/encrypted-secrets) to make the email delivery secure.
 
-
 ### Credits
+
 Repository created from [action-send-mail](https://github.com/dawidd6/action-send-mail).

test/helloWorld.js

@@ -1,13 +1,13 @@
 //Test HelloWorld
-const http = require('http');
+const http = require('http')
 
-const port = process.env.PORT || 3000;
+const port = process.env.PORT || 3000
 
 http.createServer(function(request, response) {
-  response.writeHead(200, {'Content-Type': 'text/plain'});
-  response.end("Hello, World!\n");
-}).listen(port);
+  response.writeHead(200, {'Content-Type': 'text/plain'})
+  response.end("Hello, World!\n")
+}).listen(port)
 
-console.log(`App is running... (port: ${port})`);
+console.log(`App is running... (port: ${port})`)
 
-process.exit(1);
+process.exit(1)