-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to JDK21 - both JDK and language level #10528
Conversation
Good job everyone! Nice to see that the work on fixing the stupid JDK bug paid off and came to a nice conclusion. |
Your code currently does not meet JabRef's code guidelines. The tool reviewdog already placed comments on GitHub to indicate the places. See the tab "Files" in you PR. Please carefully follow the setup guide for the codestyle. Afterwards, please run checkstyle locally and fix the issues. More information on code quality in JabRef is available at https://devdocs.jabref.org/getting-into-the-code/development-strategy.html. |
The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build. |
Fixes https://github.com/JabRef/jabref-issue-melting-pot/issues/309
No JDK 21u1 with Adoptium as of today (adoptium/temurin#6)
I checked available SDKs. I read through https://bell-sw.com/blog/oracle-java-alternatives-comparison-of-openjdk-distributions/#mcetoc_1h197r93f2ih and https://github.com/SAP/SapMachine/wiki/Differences-between-SapMachine-and-OpenJDK. "Liberica" came out best for me. Still using Temurin in the docs.
Mandatory checks
CHANGELOG.md
described in a way that is understandable for the average user (if applicable)