Prepares multi module build #11921
Merged
Prepares multi module build #11921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Carl Christian Snethlage <50491877+calixtus@users.noreply.github.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
The build of this PR is available at https://builds.jabref.org/pull/11921/merge. |
calixtus
previously approved these changes
Oct 14, 2024
|
The build of this PR is available at https://builds.jabref.org/pull/11921/merge. |
…uild # Conflicts: # src/main/java/org/jabref/Launcher.java
calixtus
approved these changes
Oct 14, 2024
|
The build of this PR is available at https://builds.jabref.org/pull/11921/merge. |
|
The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build. |
7 tasks
ExrosZ
pushed a commit
to ExrosZ/jabref
that referenced
this pull request
Oct 17, 2024
* Move information generator for AUX import to logic Co-authored-by: Carl Christian Snethlage <50491877+calixtus@users.noreply.github.com> * Add "static" to de-facto static methods * Use BibEntryTypesManager from preferences * Inline variables * Remove Injector from JabRefCLI * Remove --automaticallySetFileLinks because of UI dependency * Remove GuiPreferences from ArgumentProcessor * CLI must not depepend on GUI * Rename JabRefCLI to CliOptions * Introduce JabKit (by moving much Gui launching code to there) * Remove hiearchy * Fix compilation error * Fix usage of GuiPreferences in JabKit * Fix use of GUI monitors at JabKit * Remove unused variable * Rename JabKit to JabRefCli (and add logging if UICommands are left in Cli) --------- Co-authored-by: Carl Christian Snethlage <50491877+calixtus@users.noreply.github.com>
ExrosZ
pushed a commit
to ExrosZ/jabref
that referenced
this pull request
Oct 17, 2024
* Move information generator for AUX import to logic Co-authored-by: Carl Christian Snethlage <50491877+calixtus@users.noreply.github.com> * Add "static" to de-facto static methods * Use BibEntryTypesManager from preferences * Inline variables * Remove Injector from JabRefCLI * Remove --automaticallySetFileLinks because of UI dependency * Remove GuiPreferences from ArgumentProcessor * CLI must not depepend on GUI * Rename JabRefCLI to CliOptions * Introduce JabKit (by moving much Gui launching code to there) * Remove hiearchy * Fix compilation error * Fix usage of GuiPreferences in JabKit * Fix use of GUI monitors at JabKit * Remove unused variable * Rename JabKit to JabRefCli (and add logging if UICommands are left in Cli) --------- Co-authored-by: Carl Christian Snethlage <50491877+calixtus@users.noreply.github.com>
ExrosZ
pushed a commit
to ExrosZ/jabref
that referenced
this pull request
Oct 21, 2024
* Move information generator for AUX import to logic Co-authored-by: Carl Christian Snethlage <50491877+calixtus@users.noreply.github.com> * Add "static" to de-facto static methods * Use BibEntryTypesManager from preferences * Inline variables * Remove Injector from JabRefCLI * Remove --automaticallySetFileLinks because of UI dependency * Remove GuiPreferences from ArgumentProcessor * CLI must not depepend on GUI * Rename JabRefCLI to CliOptions * Introduce JabKit (by moving much Gui launching code to there) * Remove hiearchy * Fix compilation error * Fix usage of GuiPreferences in JabKit * Fix use of GUI monitors at JabKit * Remove unused variable * Rename JabKit to JabRefCli (and add logging if UICommands are left in Cli) --------- Co-authored-by: Carl Christian Snethlage <50491877+calixtus@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #11729.
I needed to remove
--automaticallySetFileLinks, because this needs a data structure pointing to an icon. Solving that will take some hours. To move forward with the multi module build, I thought its best to remove it (for know), introduce the multimodule project setup afterwards and then try to get it running again.Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)