Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OI Eval and Training Logs #7

Open
liuhengyue opened this issue Nov 19, 2023 · 4 comments
Open

OI Eval and Training Logs #7

liuhengyue opened this issue Nov 19, 2023 · 4 comments
Labels
good first issue Good for newcomers

Comments

@liuhengyue
Copy link

liuhengyue commented Nov 19, 2023

Hi,

Fantastic work and thanks for releasing the codebase!

I noticed that your evaluation on Open Images seems different from other approaches. You are computing the mean per GT triplet, instead of per predicate class. You also skip computing for "unseen" triplet. I am not sure if these modifications would introduce big differences when comparing with other methods. Would you mind explain this?

I also would like to ask if you have the training logs that could share, especially on mAPs results for Open Images (object detection results per class, and predicate recall per class).

Thanks.

@liuhengyue liuhengyue changed the title Training Logs OI Eval and Training Logs Nov 20, 2023
@JacobYuan7
Copy link
Owner

@liuhengyue
Hi, can you be more specific on "You are computing the mean per GT triplet, instead of per predicate class." and "You also skip computing for "unseen" triplet."? It is been a while since I use this codebase so I might forget some of the details.

In terms of the log, I will try to find one (I am a bit oocupied lately.).

@liuhengyue
Copy link
Author

@liuhengyue Hi, can you be more specific on "You are computing the mean per GT triplet, instead of per predicate class." and "You also skip computing for "unseen" triplet."? It is been a while since I use this codebase so I might forget some of the details.

In terms of the log, I will try to find one (I am a bit oocupied lately.).

Thanks for your quick reply. I was refering to the code starting

for triplet in self.gt_triplets:

The ap is computed per GT triplet, whereas people compute per predicate class.

The skip for unssen triplet is related to the codes below

if triplet not in self.gt_triplets:
continue

@JacobYuan7
Copy link
Owner

JacobYuan7 commented Nov 21, 2023

@liuhengyue
For the first query, according to my scope of knowledge, it is usually computed per triplet. Usually, performance per triplet will be lower than performance per predicate since we have much more classes.

For the second query, this is the default operation in mAP calculation for HOI detection. As I remember it, typical SGG mAP calculation has also done something similar to this. I assume that performance will degrade if we do not do this.

@JacobYuan7
Copy link
Owner

@liuhengyue
These are the training logs that you required. (For Swin-T, there are repetitve results due to multiple tries. Generally, they adhere to the reported results in the paper.)

RLIP_PDA_v2_OISGGtrain_SwinL_VGCOCOO365_RQL_LSE_RPL_20e_L1_20e.txt

RLIP_PDA_v2_OISGGtrain_SwinT_VGCOCOO365_RQL_LSE_RPL_20e_L1_20e.txt

RLIP_PDA_v2_OISGGtrain_R50_VGCOO365_RQL_LSE_RPL_20e_L1_20e.txt

@JacobYuan7 JacobYuan7 added the good first issue Good for newcomers label Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants