You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I wanted to start the discussion of potentially removing the usage of actions/checkout as a dependency. I think while actions/checkout is maintained by GitHub themselves, an MVP is easily replicated and will reduce a lot of confusion when creating a workflow. All you'd need to do is add this action.
I believe the API additions would need to be as so:
CHECKOUT: Toggles the internal checkout process on/off. I think this should be optional to turn off if people have complex workflows that require more features. This could be eventually deprecated.
LFS: This is already a toggle, but the necessary fetch/setup commands could be run as a result of this if toggled.
SUBMODULES: Runs the necessary setup commands to download submodules.
There would also be a way to run any pre-deploy commands. As right now you can add a step between checkout and deployment we'd need to preserve this behavior for things like yarn build. Perhaps an EXECUTE argument would suffice within a try/catch block.
If you have any thoughts on this please feel free to share them! This is just a suggestion/idea right now, and may not be implemented depending on the scope.
This discussion was converted from issue #455 on October 14, 2020 04:25.
Heading
Bold
Italic
Quote
Code
Link
Numbered list
Unordered list
Task list
Attach files
Mention
Reference
Menu
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
I wanted to start the discussion of potentially removing the usage of
actions/checkout
as a dependency. I think whileactions/checkout
is maintained by GitHub themselves, an MVP is easily replicated and will reduce a lot of confusion when creating a workflow. All you'd need to do is add this action.I believe the API additions would need to be as so:
CHECKOUT: Toggles the internal checkout process on/off. I think this should be optional to turn off if people have complex workflows that require more features. This could be eventually deprecated.
LFS: This is already a toggle, but the necessary fetch/setup commands could be run as a result of this if toggled.
SUBMODULES: Runs the necessary setup commands to download submodules.
There would also be a way to run any pre-deploy commands. As right now you can add a step between checkout and deployment we'd need to preserve this behavior for things like
yarn build
. Perhaps an EXECUTE argument would suffice within atry/catch
block.If you have any thoughts on this please feel free to share them! This is just a suggestion/idea right now, and may not be implemented depending on the scope.
Beta Was this translation helpful? Give feedback.
All reactions